-
Notifications
You must be signed in to change notification settings - Fork 271
v1.1: Add new filter rule _geoBoundingBox
#2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
_geoboundingbox_geoBoundingBox
alallema
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked the code-sample but LGTM! 🎉
maryamsulemani97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the last bullet for the following errors in /reference/errors/error_codes.md:
invalid_settings_ranking_rulesinvalid_search_sortinvalid_search_filter
to:
A reserved keyword like _geo, _geoDistance, _geoPoint, _geoRadius or _geoBoundingBox is used…
|
@maryamsulemani97: is the list of reserved words exhaustive? If so, does it have to be? |
It isn't. We can document this somewhere else if needed |
|
Ok, so after some actual testing I realised there's no "one size fits all" solution here. This is what we'll do:
|
maryamsulemani97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍎
Co-authored-by: Tamo <[email protected]>
|
bors merge |
|
Build succeeded: |
Closes #2201